Skip to content

Refactor reconciliation interfaces into messages #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Feb 27, 2025

Pull Request

Refactor order report interfaces into messages

Similar refactor as for data messages.
Using messages makes it clearer to understand where interfaces between component are located.

This also opens up the way to call execution client's order report functionalities from other components through messages if necessary in the future.

Type of change

  • Refactor

How has this change been tested?

Adapted existing tests

@cjdsellers cjdsellers changed the title Refactor order report interfaces into messages Refactor reconciliation interfaces into messages Feb 27, 2025
@cjdsellers
Copy link
Member

cjdsellers commented Feb 27, 2025

Hi @faysou

Thanks again for the contribution!

I think this is a good change because it makes the client interfaces even more standardized after you went to the trouble of refactoring the other data interfaces to messages to match the style of the execution side 👍.

For internal interfaces like this, messages work well, but we should avoid refactoring every interface to messages - especially user facing API's where they don't need to be exposed to the underlying messaging architecture.

This also opens up the way to call execution client's order report functionalities from other components through messages if necessary in the future.

I think we want to avoid the complexity of any component being able to call these interfaces, and keep them "owned" by the DataEngine and ExecutionEngine so that flows are easier to reason about - unless there's a very strong design reason later on of course.

@cjdsellers cjdsellers merged commit 8c50d3c into develop Feb 27, 2025
12 checks passed
@cjdsellers cjdsellers deleted the reportsrefactor branch February 27, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants