Skip to content

BlueScreen: fixed PHP 8.4 exception in generator #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BlueScreen: fixed PHP 8.4 exception in generator #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Tracy/BlueScreen/BlueScreen.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,12 @@ private function findGeneratorsAndFibers(object $object): array
$add = function ($obj) use (&$generators, &$fibers) {
if ($obj instanceof \Generator) {
try {
new \ReflectionGenerator($obj);
$ref = new \ReflectionGenerator($obj);
// Before PHP 8.4 the ReflectionGenerator cannot be constructed from closed generator.
// Since PHP 8.4 it can, but getTrace throws ReflectionException.
if (PHP_VERSION_ID >= 80400 && $ref->isClosed()) {
return;
}
$generators[spl_object_id($obj)] = $obj;
} catch (\ReflectionException) {
}
Expand Down
37 changes: 37 additions & 0 deletions tests/Tracy/Debugger.exception.in-generator.html.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?php

/**
* Test: Tracy\Debugger exception in generator in HTML.
* @phpVersion 8.1 ReflectionGenerator::getTrace() is empty in PHP < 8.1
* @httpCode 500
* @exitCode 255
* @outputMatchFile expected/Debugger.exception.in-generator.html.expect
*/

declare(strict_types=1);

use Tracy\Debugger;

require __DIR__ . '/../bootstrap.php';

if (PHP_SAPI === 'cli') {
Tester\Environment::skip('Debugger Bluescreen is not rendered in CLI mode');
}


Debugger::$productionMode = false;
setHtmlMode();

Debugger::enable();


$generator = (function (): iterable {
yield 5;
throw new Exception('The my exception', 123);
})();
$fn = function ($generator) {
foreach ($generator as $value) {
}
};

$fn($generator);
119 changes: 119 additions & 0 deletions tests/Tracy/expected/Debugger.exception.in-generator.html.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
<!DOCTYPE html><!-- "' --></textarea></script></style></pre></xmp></a></iframe></noembed></noframes></noscript></option></select></template></title></table></p></code>
<html>
<head>
<meta charset="utf-8">
<meta name="robots" content="noindex">
<meta name="generator" content="Tracy by Nette Framework">

<title>Exception: The my exception #123</title>
<!-- in %a%:%d% -->
<!-- %a% -->

%A%
</head>


<body>
<tracy-div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle">&#xfeff;</a>
<div class="tracy-bs-main">
<section class="tracy-section tracy-section--error">
<p>Exception #123</p>

<h1><span>The my exception</span>
<a href="%a%" class="tracy-action" target="_blank" rel="noreferrer noopener">search&#x25ba;</a>
</h1>

</section>



<section class="tracy-section">
<h2 class="tracy-section-label"><a href="#" data-tracy-ref="^+" class="tracy-toggle">Source file</a></h2>

<div class="tracy-section-panel">
<p><b>File:</b> <a href="%a%" title="%a%" class="tracy-editor">%a%<b>Debugger.exception.in-generator.html.phpt</b>:%d%</a></p>
<pre title="Ctrl-Click to open in editor" data-tracy-href="%a%" class='tracy-code'><div><code><span class='tracy-code-keyword'><span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span>Debugger<span class='tracy-code-keyword'>::</span><span class='tracy-code-var'>$productionMode </span><span class='tracy-code-keyword'>= </span>false<span class='tracy-code-keyword'>;
<span class='tracy-line'>%d%:</span> </span>setHtmlMode<span class='tracy-code-keyword'>();
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span>Debugger<span class='tracy-code-keyword'>::</span>enable<span class='tracy-code-keyword'>();
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$generator </span><span class='tracy-code-keyword'>= (function (): </span>iterable <span class='tracy-code-keyword'>{
<span class='tracy-line'>%d%:</span> yield </span><span class='tracy-dump-number'>5</span><span class='tracy-code-keyword'>;
</span><span class='tracy-line-highlight'>%d%: throw new Exception('The my exception', 123);</span>
<span class='tracy-code-keyword'><span class='tracy-line'>%d%:</span> })();
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$fn </span><span class='tracy-code-keyword'>= function (</span><span class='tracy-code-var'>$generator</span><span class='tracy-code-keyword'>) {
<span class='tracy-line'>%d%:</span> foreach (</span><span class='tracy-code-var'>$generator </span><span class='tracy-code-keyword'>as </span><span class='tracy-code-var'>$value</span><span class='tracy-code-keyword'>) {
<span class='tracy-line'>%d%:</span> }
</span></code></div></pre>
</div>
</section>

<section class="tracy-section">
<h2 class="tracy-section-label"><a href="#" data-tracy-ref="^+" class="tracy-toggle">Call stack</a></h2>

<div class="tracy-section-panel">
<div class="tracy-callstack">

<div class="tracy-callstack-file">
<a href="%a%" title="%a%" class="tracy-editor">%a%<b>Debugger.exception.in-generator.html.phpt</b>:%d%</a>
</div>

<div class="tracy-callstack-callee">
<a href="#" data-tracy-ref="^div + div" class="tracy-toggle tracy-collapsed"><b>{closure%a?%}</b> ()</a>
</div>

<div class="tracy-callstack-additional tracy-collapsed">
<pre title="Ctrl-Click to open in editor" data-tracy-href="%a%" class='tracy-code'><div><code><span class='tracy-code-keyword'><span class='tracy-line'>%d%:</span> </span>setHtmlMode<span class='tracy-code-keyword'>();
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span>Debugger<span class='tracy-code-keyword'>::</span>enable<span class='tracy-code-keyword'>();
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$generator </span><span class='tracy-code-keyword'>= (function (): </span>iterable <span class='tracy-code-keyword'>{
<span class='tracy-line'>%d%:</span> yield </span><span class='tracy-dump-number'>5</span><span class='tracy-code-keyword'>;
<span class='tracy-line'>%d%:</span> throw new </span>Exception<span class='tracy-code-keyword'>(</span><span class='tracy-dump-string'>'The my exception'</span><span class='tracy-code-keyword'>, </span><span class='tracy-dump-number'>123</span><span class='tracy-code-keyword'>);
<span class='tracy-line'>%d%:</span> })();
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$fn </span><span class='tracy-code-keyword'>= function (</span><span class='tracy-code-var'>$generator</span><span class='tracy-code-keyword'>) {
</span><span class='tracy-line-highlight'>%d%: foreach ($generator as $value) {</span>
<span class='tracy-code-keyword'><span class='tracy-line'>%d%:</span> }
<span class='tracy-line'>%d%:</span> };
<span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$fn</span><span class='tracy-code-keyword'>(</span><span class='tracy-code-var'>$generator</span><span class='tracy-code-keyword'>);</span>
</code></div></pre>

</div>

<div class="tracy-callstack-file">
<a href="%a%" title="%a%" class="tracy-editor">%a%<b>Debugger.exception.in-generator.html.phpt</b>:%d%</a>
</div>

<div class="tracy-callstack-callee">
<a href="#" data-tracy-ref="^div + div" class="tracy-toggle tracy-collapsed"><b>{closure%a?%}</b> (...)</a>
</div>

<div class="tracy-callstack-additional tracy-collapsed">
<pre title="Ctrl-Click to open in editor" data-tracy-href="%a%" class='tracy-code'><div><code><span class='tracy-code-keyword'><span class='tracy-line'>%d%:</span>
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$generator </span><span class='tracy-code-keyword'>= (function (): </span>iterable <span class='tracy-code-keyword'>{
<span class='tracy-line'>%d%:</span> yield </span><span class='tracy-dump-number'>5</span><span class='tracy-code-keyword'>;
<span class='tracy-line'>%d%:</span> throw new </span>Exception<span class='tracy-code-keyword'>(</span><span class='tracy-dump-string'>'The my exception'</span><span class='tracy-code-keyword'>, </span><span class='tracy-dump-number'>123</span><span class='tracy-code-keyword'>);
<span class='tracy-line'>%d%:</span> })();
<span class='tracy-line'>%d%:</span> </span><span class='tracy-code-var'>$fn </span><span class='tracy-code-keyword'>= function (</span><span class='tracy-code-var'>$generator</span><span class='tracy-code-keyword'>) {
<span class='tracy-line'>%d%:</span> foreach (</span><span class='tracy-code-var'>$generator </span><span class='tracy-code-keyword'>as </span><span class='tracy-code-var'>$value</span><span class='tracy-code-keyword'>) {
<span class='tracy-line'>%d%:</span> }
<span class='tracy-line'>%d%:</span> };
<span class='tracy-line'>%d%:</span>
</span><span class='tracy-line-highlight'>%d%: $fn($generator);</span>
</code></div></pre>

<table class="tracy-callstack-args">
<tr><th>#0</th><td><pre class="tracy-dump tracy-light" data-tracy-dump='%a%'></pre>
</td></tr>
</table>
</div>
</div>
</div>
</section>
%A%