Skip to content

feat: pass stack config through to pulumi providers #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

asalkeld
Copy link
Contributor

@asalkeld asalkeld commented Sep 2, 2022

I used a stack config of :

name: staging
provider: gcp
region: australia-southeast1
project: thing
config:
  default:
    memory: 512
  functions/api/main.go:
    timeout: 30

@asalkeld asalkeld force-pushed the feature/stack-func-config branch 2 times, most recently from 1b44960 to 14ae7cb Compare September 2, 2022 05:51
@asalkeld asalkeld marked this pull request as ready for review September 2, 2022 05:52
@asalkeld asalkeld requested a review from jyecusch September 2, 2022 05:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 33.33% // Head: 32.29% // Decreases project coverage by -1.03% ⚠️

Coverage data is based on head (6bd2ddc) compared to base (0c9439e).
Patch coverage: 19.79% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #329      +/-   ##
===========================================
- Coverage    33.33%   32.29%   -1.04%     
===========================================
  Files           52       52              
  Lines         4803     4908     +105     
===========================================
- Hits          1601     1585      -16     
- Misses        3053     3168     +115     
- Partials       149      155       +6     
Flag Coverage Δ
unittests 32.29% <19.79%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/codeconfig/codeconfig.go 7.55% <0.00%> (ø)
pkg/project/types.go 8.76% <ø> (ø)
pkg/provider/pulumi/azure/azure.go 5.63% <0.00%> (-0.80%) ⬇️
pkg/provider/pulumi/common/types.go 0.00% <ø> (ø)
pkg/stack/options.go 23.33% <ø> (+3.88%) ⬆️
pkg/provider/pulumi/gcp/gcp.go 40.00% <5.26%> (-8.35%) ⬇️
pkg/provider/pulumi/aws/aws.go 51.06% <30.00%> (-9.77%) ⬇️
pkg/project/options.go 62.50% <88.23%> (+1.97%) ⬆️
pkg/provider/pulumi/aws/lambda.go 70.79% <100.00%> (-0.51%) ⬇️
pkg/provider/pulumi/gcp/cloudrunner.go 78.57% <100.00%> (-0.19%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asalkeld asalkeld force-pushed the feature/stack-func-config branch from 14ae7cb to a204d7b Compare September 2, 2022 06:28
@asalkeld asalkeld marked this pull request as draft September 4, 2022 23:04
Copy link
Member

@tjholm tjholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one comment.

@jyecusch was also looking at updating the defaults for AWS to get higher default vCPU allocation.

@asalkeld asalkeld closed this Sep 5, 2022
@asalkeld asalkeld reopened this Sep 5, 2022
@asalkeld asalkeld force-pushed the feature/stack-func-config branch from a204d7b to e02177d Compare September 5, 2022 01:14
@asalkeld asalkeld marked this pull request as ready for review September 5, 2022 01:15
@asalkeld asalkeld force-pushed the feature/stack-func-config branch from e02177d to 6bd2ddc Compare September 5, 2022 01:23
@tjholm tjholm merged commit 2b6677a into nitrictech:develop Sep 5, 2022
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants