refactor: renamed PriceWithDiscount to PriceWithoutDiscount #7656
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KaranChadha10. Thank you very much for your willingness to help. Sorry for not looking at your code for a long time. Unfortunately, the essence of the ticket is a bit more complicated than just renaming one field. At a minimum, you also need to rename the PriceWithDiscountValue field. But even that's not all, the value in the new field also needs to be set with another variable. Also, the location of the field display on the view should change, as well as the locale. Unfortunately, I can't accept your PR in this form. If you want to continue working on the task, then let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the following points:
PriceWithDiscounttoPriceWithoutDiscountin theProductPriceModel.csclass._ProductPrice.cshtmlview.ProductModelFactoryTests.cs.Issue Link: #7654