Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

[BUG] update to mkdirp ≥ 1 #69

Open
@guimard

Description

@guimard

What / Why

mkdirp is outdated.

Proposed patch:

--- a/lib/dir-writer.js
+++ b/lib/dir-writer.js
@@ -31,12 +31,12 @@

 DirWriter.prototype._create = function () {
   var self = this
-  mkdir(self._path, Writer.dirmode, function (er) {
-    if (er) return self.error(er)
-    // ready to start getting entries!
+  mkdir(self._path, Writer.dirmode).then( () => {
     self.ready = true
     self.emit('ready')
     self._process()
+  }).catch( (er) => {
+    return self.error(er)
   })
 }

--- a/lib/writer.js
+++ b/lib/writer.js
@@ -166,13 +166,13 @@

   // XXX Need to clobber non-dirs that are in the way,
   // unless { clobber: false } in the props.
-  mkdir(path.dirname(self._path), Writer.dirmode, function (er, made) {
-    // console.error("W created", path.dirname(self._path), er)
-    if (er) return self.error(er)
-
+  mkdir(path.dirname(self._path), Writer.dirmode).then( (made) => {
     // later on, we have to set the mode and owner for these
     self._madeDir = made
     return self._create()
+  }).catch( (er) => {
+    // console.error("W created", path.dirname(self._path), er)
+    return self.error(er)
   })
 }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions