Numpydoc 1.9.0: AttributeError: 'property' object has no attribute '__module__'.

[jeremiedbb]

Hi,

It looks like version 1.9.0 introduced a regression in the validation of property objects:
AttributeError: 'property' object has no attribute '__module__'.

It was detected in scikit-learn's CI; https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=77826&view=logs&jobId=dfe99b15-50db-5d7b-b1e9-4105c42527cf&j=dfe99b15-50db-5d7b-b1e9-4105c42527cf&t=ef785ae2-496b-5b02-9f0e-07a6c3ab3081

It can be reproduced by calling:
numpydoc.validate.validate("sklearn.model_selection._classification_threshold.FixedThresholdClassifier.classes_")

[Revathyvenugopal162]

We’re encountering a similar error in our libraries after upgrading to numpydoc 1.9.0 build: bump numpydoc from 1.8.0 to 1.9.0 ansys/ansys-sphinx-theme#735. The Sphinx build fails with the following message:

Extension error (numpydoc.numpydoc):
Handler <function mangle_docstrings at 0x7f13208353f0> for event 'autodoc-process-docstring' threw an exception (exception: 'NoneType' object has no attribute '__module__')

This seems consistent with the regression described above.

[argerlt]

AHA! I'm not going crazy! I had the same problem recently in another project, orix

I created two different identical branches, and ran both through the ReadtheDocs automated builder, one with 18.0, the other with 19.0
The first one succeeds: https://app.readthedocs.org/projects/orix/builds/28318535/

The second one fails: https://app.readthedocs.org/projects/orix/builds/28726013/

It looks like it fails when trying to parse the class propertyIpf_color_key_tsl.direction_color_key

I think the change that caused the problem was this one

I am not familiar enough with numpydoc to be sure, but is it sufficient to just add
type(Rotation.angle) != property at line 640 of validate.py?