Add warpAffine and resizeDown APIs in FastCV Extension #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @asmorkalov, i think we don't need dummy PR for this |
asmorkalov
reviewed
May 19, 2025
| * | ||
| * @return Returns 0 if the transformation is valid. | ||
| */ | ||
| CV_EXPORTS_W void warpAffineROI(InputArray _src, const cv::Point2f& position, InputArray _affine, OutputArray _patch, Size patchSize); |
There was a problem hiding this comment.
Technically, the API is redundant. OpenCV cv::Mat has locateRoi method that may extract details of the original matrix, if roi is provided as a parameter. You can just handle the case in existing warpAffine.
There was a problem hiding this comment.
in warpAffineROI, we use fcvTransformAffineu8_v2 which uses 2x2 Affine transformation and also uses fixed point precision, that's why it was added separately
|
@asmorkalov unified warpAffine, warpAffine3Channel, and warpAffineROI into a single warpAffine function |
…o a single warpAffine function
quic-apreetam
force-pushed
the
apreetam_6thPost
branch
from
de19687 to
f373ee2
Compare
asmorkalov
approved these changes
Jun 9, 2025
Merged
dbouron
pushed a commit
to criteo-forks/opencv_contrib
that referenced
this pull request
Jun 23, 2025
Add warpAffine and resizeDown APIs in FastCV Extension opencv#3936 - Added warpAffine function to apply affine transformations. 2x3 affine transformations for both CV_8UC1 and CV_8UC3 input 2x2 matrix-based patch extraction for grayscale images, with ROI. - Deprecated resizeDownBy2 and resizeDownBy4 functions. - Introduced resizeDown function to down-scale images using specified scaling factors or dimensions, supporting both single-channel (CV_8UC1) and two-channel (CV_8UC2) images. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warpAffine function to apply affine transformations.
2x3 affine transformations for both CV_8UC1 and CV_8UC3 input
2x2 matrix-based patch extraction for grayscale images, with ROI.
Deprecated resizeDownBy2 and resizeDownBy4 functions.
Introduced resizeDown function to down-scale images using specified scaling factors or dimensions, supporting both single-channel (CV_8UC1) and two-channel (CV_8UC2) images.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.