Skip to content

docs: mermaid support #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Mar 22, 2022
Merged

docs: mermaid support #1053

merged 33 commits into from
Mar 22, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 21, 2022

No description provided.

csviri and others added 11 commits March 21, 2022 08:56
@csviri
docs: dependent resources
33155ed
@csviri
docs: dr motivation
b66fa9e
@metacosm @csviri
docs: add flow chart to motivation, detail design
671f9bf
@metacosm @csviri
fix: remove now fixed fix-me :)
8e89c61 
[skip-ci]
@metacosm @scrocquesel
fix: missing word
7235a96 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel
fix: re-order sentences
8b1878b 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel
fix: clarify
6dc9924 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel
fix: split sentence
d6fe862 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel
fix: split sentence
4ad2f55 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel
fix: remove extra word
21a4385 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@csviri
fix: header
c4f031b
csviri
csviri commented Mar 21, 2022
View reviewed changes
docs/documentation/dependent-resources.md Outdated
match -- No --> Update

```
<div class="mermaid"> graph TD; A-->B; A-->C; </div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working yet, just a test simple graph

@csviri csviri self-assigned this Mar 21, 2022
@csviri
Copy link
Collaborator Author

csviri commented Mar 21, 2022 •
edited
Loading

https://medium.com/@wangling1882/how-to-use-mermaid-in-jekyll-without-plugin-ec0c1255eb90

found this also: https://stackoverflow.com/questions/53883747/how-to-make-github-pages-markdown-support-mermaid-diagram

csviri and others added 10 commits March 21, 2022 16:38
@csviri
docs: dependent resources
45aa0ab
@csviri
docs: dr motivation
a7e5e08
@metacosm @csviri
docs: add flow chart to motivation, detail design
aaf9e63
@metacosm @csviri
fix: remove now fixed fix-me :)
c66c5b8 
[skip-ci]
@metacosm @scrocquesel @csviri
fix: missing word
4a5db14 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel @csviri
fix: re-order sentences
e422b2a 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel @csviri
fix: clarify
ba3122a 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel @csviri
fix: split sentence
a61c054 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel @csviri
fix: split sentence
c8c6382 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
@metacosm @scrocquesel @csviri
fix: remove extra word
4c7fe86 
Co-authored-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
csviri and others added 3 commits March 21, 2022 16:38
@csviri
fix: header
badc61c
@metacosm @csviri
fix: simplify dependent logic [skip-ci]
37c8796
@metacosm @csviri
fix: reword
9453108 
[skip ci]

Co-authored-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri force-pushed the docs-dependent-resources branch from 8728633 to 9453108 Compare March 21, 2022 15:38
@csviri csviri marked this pull request as ready for review March 21, 2022 16:00
@csviri csviri requested a review from metacosm March 21, 2022 16:00
Base automatically changed from docs-dependent-resources to next March 22, 2022 11:40
@csviri
Merge branch 'next' into mermaid-in-docs
c392542 
# Conflicts:
#	docs/documentation/dependent-resources.md
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 64 Code Smells

39.8% 39.8% Coverage
0.3% 0.3% Duplication

@metacosm metacosm merged commit 8078fec into next Mar 22, 2022
@metacosm metacosm deleted the mermaid-in-docs branch March 22, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm Awaiting requested review from metacosm

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm