Skip to content

fix: Issue for "Operator Couldn't start source ..." #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2022
Merged

fix: Issue for "Operator Couldn't start source ..." #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19f695b
fix: Issue for "Operator Couldn't start source ..."
csviri Mar 23, 2022
6a4aae6
fix: small fixes
csviri Mar 23, 2022
08e01b5
fix: comment
csviri Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...r-framework-junit5/src/main/java/io/javaoperatorsdk/operator/junit/OperatorExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.function.Consumer;
import java.util.stream.Collectors;
import java.util.stream.Stream;
Expand Down Expand Up @@ -100,8 +99,11 @@ protected void before(ExtensionContext context) {
try (InputStream is = getClass().getResourceAsStream(path)) {
final var crd = kubernetesClient.load(is);
crd.createOrReplace();
crd.waitUntilReady(2, TimeUnit.SECONDS);
Thread.sleep(2000); // readiness is not applicable for CRD, just wait a little
LOGGER.debug("Applied CRD with name: {}", config.getResourceTypeName());
} catch (InterruptedException ex) {
LOGGER.error("Interrupted.", ex);
Thread.currentThread().interrupt();
} catch (Exception ex) {
throw new IllegalStateException("Cannot apply CRD yaml: " + path, ex);
}
Expand Down
3 changes: 0 additions & 3 deletions ...c/test/java/io/javaoperatorsdk/operator/sample/event/EventSourceTestCustomReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.concurrent.atomic.AtomicInteger;

import io.javaoperatorsdk.operator.ReconcilerUtils;
import io.javaoperatorsdk.operator.api.reconciler.*;
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
import io.javaoperatorsdk.operator.support.TestExecutionInfoProvider;
Expand All @@ -12,8 +11,6 @@ public class EventSourceTestCustomReconciler
implements Reconciler<EventSourceTestCustomResource>,
TestExecutionInfoProvider {

public static final String FINALIZER_NAME =
ReconcilerUtils.getDefaultFinalizerName(EventSourceTestCustomResource.class);
public static final int TIMER_PERIOD = 500;
private final AtomicInteger numberOfExecutions = new AtomicInteger(0);

Expand Down
1 change: 0 additions & 1 deletion operator-framework/src/test/java/io/javaoperatorsdk/operator/support/TestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class TestUtils {

public static final String TEST_CUSTOM_RESOURCE_PREFIX = "test-custom-resource-";
public static final String TEST_CUSTOM_RESOURCE_NAME = "test-custom-resource";
public static final String TEST_NAMESPACE = "java-operator-sdk-int-test";

public static TestCustomResource testCustomResource() {
return testCustomResource(UUID.randomUUID().toString());
Expand Down