fix: same as controller config for KubernetesDependentResource standalone #1222
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -49,12 +51,17 @@ public KubernetesDependentResource(Class<R> resourceType) { | |||
|
|
|||
| @Override | |||
| public void configureWith(KubernetesDependentResourceConfig config) { | |||
| configureWith(config.labelSelector(), config.namespaces(), !config.wereNamespacesConfigured()); | |||
| this.kubernetesDependentResourceConfig = config; | |||
There was a problem hiding this comment.
Shouldn't we call configureWith(…) here?
There was a problem hiding this comment.
we dont, have the context here, so we don't know the controller namespaces. So it cannot be done at this time.
There was a problem hiding this comment.
So when is it done, then? The expectation with the configureWith methods is that once they're called, the dependent resource is set up. In this case, this isn't true anymore and someone calling this method would need to call one of the other versions at some later time…
| configureWith(null, context.getControllerConfiguration().getNamespaces(), true); | ||
| log.warn("Using default configuration for " + resourceType().getSimpleName() | ||
| + " KubernetesDependentResource, call configureWith to provide configuration"); | ||
| if (kubernetesDependentResourceConfig != null) { |
There was a problem hiding this comment.
@metacosm it's done here, when the event source is created.
There was a problem hiding this comment.
🤔 I saw that but wasn't convinced there wasn't a path where this wouldn't get called… But I guess createEventSource is always called so we should be good! Thanks!
No description provided.