feat: retry remove finalizer #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2022
metacosm
requested changes
May 30, 2022
| @@ -19,7 +20,7 @@ class EventMarker { | |||
|
|
|||
| public enum EventingState { | |||
| /** Event but NOT Delete event present */ | |||
There was a problem hiding this comment.
This javadoc is confusing since it's unclear to which constant it applies…
Comment on lines
167
to
173
| * if already processed mark for deletion we want to override that mark in case a custom | ||
| * resource in the cache and not it is not marked for deletion. This could happen in an edge | ||
| * case, when the resource is deleted while websocket was disconnected. And meanwhile a | ||
| * resource with same ResourceID was deleted and created again. So resource should not be | ||
| * marked received if processedMarkForDeletion present it's still marked for deletion, but | ||
| * otherwise yes. | ||
| */ |
There was a problem hiding this comment.
I don't really understand the comment…
There was a problem hiding this comment.
reformulated, it's more like documenting an edge case that is not explicit, hope its better now
| @@ -35,6 +37,8 @@ | |||
| */ | |||
| class ReconciliationDispatcher<R extends HasMetadata> { | |||
|
|
|||
| public static final int MAX_FINALIZER_REMOVAL_RETRY = 10; | |||
There was a problem hiding this comment.
Maybe that should be configurable from the ConfigurationService?
There was a problem hiding this comment.
Would do it a separate PR TBH. Ideally this retry passes after 1-2 attemt, it's unlikely that there will be more than 3-4 finalizers.
There was a problem hiding this comment.
Yes, this should be done in a different PR for sure.
metacosm
approved these changes
May 30, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.