refactor: move integration tests to feature packages and sub packages based on type #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
For now 2 categories:
|
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
changed the title
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
reviewed
Aug 8, 2024
| @@ -42,14 +43,14 @@ void cleanerIsCalledOnBuiltInResource() { | |||
| operator.delete(service); | |||
|
|
|||
| await().untilAsserted(() -> { | |||
| assertThat(operator.getReconcilerOfType(ObservedGenerationTestReconciler.class) | |||
| assertThat(operator.getReconcilerOfType(BuiltInResourceCleanerReconciler.class) | |||
| .getCleanCount()).isPositive(); | |||
| }); | |||
| } | |||
|
|
|||
| Service testService() { | |||
| Service service = ReconcilerUtils.loadYaml(Service.class, StandaloneDependentResourceIT.class, | |||
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm
approved these changes
Aug 8, 2024
csviri
added a commit
that referenced
this pull request
Aug 15, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Aug 16, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Aug 29, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Oct 10, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 5, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 6, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 19, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 20, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 27, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.