Native compilation improvements #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to avoid having to register Jackson's ClassSerializer class, not to mention the fact that it really doesn't make sense to serialize the class in the first place.
This is currently not working very well because for some reason, the native test is run even when the native profile isn't activated when it shouldn't be, hence the current exclusion in the surefire configuration). More importantly, though, it's not activated either when the profile is activated so something is going on that I'm just not seeing right now. Committing for sync purposes.
metacosm
force-pushed
the
native-compilation
branch
from
b8a18cd to
f124dda
Compare
adam-sandor
reviewed
Jan 14, 2021
| ConfigurationServiceRecorder recorder) { | ||
| final var index = combinedIndexBuildItem.getIndex(); | ||
| final var resourceControllers = index.getAllKnownImplementors(RESOURCE_CONTROLLER); | ||
|
|
||
| final var classOutput = new GeneratedClassGizmoAdaptor(generatedClass, true); | ||
| final List<ControllerConfiguration> controllerConfigs = | ||
| resourceControllers.stream() | ||
| .map(ci -> createControllerConfiguration(ci, classOutput, additionalBeans)) | ||
| .map( |
There was a problem hiding this comment.
ouch.. did the fmt plugin do this?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.