Skip to content

feat: add @Ignore annotation to mark internal Reconciler implementations #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

metacosm
Copy link
Collaborator

This allows downstream tools to safely ignore the annotated Reconciler
when considering which implementations to process.

Fixes #862

This allows downstream tools to safely ignore the annotated Reconciler
when considering which implementations to process.

Fixes #862
@metacosm metacosm added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2022
@metacosm metacosm self-assigned this Jan 24, 2022
@metacosm metacosm requested a review from csviri January 24, 2022 18:05
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 17 Code Smells

28.0% 28.0% Coverage
0.9% 0.9% Duplication

@metacosm metacosm merged commit 06893df into next Jan 25, 2022
@metacosm metacosm deleted the fix-862 branch January 25, 2022 12:47
metacosm added a commit that referenced this pull request Jan 28, 2022
…ons (#863)

This allows downstream tools to safely ignore the annotated Reconciler
when considering which implementations to process.

Fixes #862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants