Skip to content

feat: remove feature of filter event with observed generation #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Feb 2, 2022

From now on on startup we always reconcile the resources. Since deletes cannot be detected automatically, thus if a resource deletion happens while de operator is down, it won't trigger a reconciliation on startup. So this is important for correctness in general.

@csviri csviri requested a review from metacosm February 2, 2022 14:22
@csviri csviri self-assigned this Feb 2, 2022
@csviri csviri closed this Feb 2, 2022
@csviri csviri reopened this Feb 2, 2022
@csviri csviri merged commit 7b2189f into main Feb 2, 2022
@csviri csviri deleted the generation-aware-only-in-memory branch February 2, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PollingEventSource should trigger reconcile when a secondary resource is missing
2 participants