Configuration polish #926
Merged
Configuration polish #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
commented
Feb 11, 2022
| @@ -12,15 +12,13 @@ | |||
| public @interface KubernetesDependent { | |||
|
|
|||
| boolean OWNED_DEFAULT = true; | |||
| boolean SKIP_UPDATE_DEFAULT = true; | |||
There was a problem hiding this comment.
We might want to put this back, it was then used in informer as recognized later, but still don't understand why was it added in first place.
…ava-operator-sdk into configuration-polish
* refactor: DependentResourceManager now configures DependentResources This makes it possible to pass a configuration DependentResource implementations and removes the need to initializers. * refactor: remove DesiredSupplier since it makes things less readable
|
Shouldn't have you merged this one before the other one? |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.