Bug/63665 project level lifecycle phases are clickable for non enterprise users #19115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinLama
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Works like a charm! 👏🏻
While reviewing, I was wondering why there were no specs changed or added in this PR, but found that we have specs for this case - only that it's not specifically checking if there is a link that can then be followed.
I think our current specs are enough and it's not necessary to add yet another one for this tiny case. If you agree, feel free to merge 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/63665
What are you trying to accomplish?
Only displays a link if the user is admin and an enterprise token allows modifying the phase definition.
Additionally, it clarifies the namespace of the components used in Projects -> Settings -> Life cycle. Since it is inside the life cycle UI, the components get that namespace. The component responsible for rendering every phase is renamed accordingly.