[FSSDK-11207] add multi region support for logx events #1072
+198
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds multi-region support for logx events by introducing a new Region type and updating event building functions to dispatch events to region-specific endpoints.
- Added a new Region type and updated the ProjectConfig interface to include a region property with a default fallback to 'US'.
- Modified user event creation and log event construction to include region information and updated tests accordingly.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/project_config/project_config.ts | Added the Region type and default region assignment |
| lib/project_config/project_config.spec.ts | Added tests verifying region defaulting and parsing |
| lib/event_processor/event_builder/user_event.ts | Included region in event context and equality checks |
| lib/event_processor/event_builder/user_event.tests.js | Added region to test event objects |
| lib/event_processor/event_builder/log_event.ts | Updated log event construction to use region-specific URLs |
| lib/event_processor/event_builder/log_event.spec.ts | Added tests for verifying the correct logx endpoint selection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
logx event will now be dispatched to different urls based on region field in the datafile
Test plan
Issues