Skip to content

[FSSDK-10643] make event processor injectable #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • Modify the instantiation API so that the user can inject an event processor directly. Also expose createStaticEventProcessor factory method.

Test plan

  • New tests has been added and relevant tests has been refactored

Issues

  • FSSDK-10643

@coveralls
Copy link

coveralls commented Sep 30, 2024

Coverage Status

coverage: 88.866% (-0.3%) from 89.201%
when pulling 676129a on raju/event-processor
into 1d814a2 on master.

Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have some queries -

  • I was going through the TDD before reviewing this and I find createQueuingEventProcessor which is missing from this commit. Are you planning to do that on the future? Or you are happy with the current createEventProcessor as it is.
  • I am seeing some commented code and unused imports across the platform specific files. I have just put "Cleanup required" for each. Pardon me if I have missed any to mark.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP still reviewing

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like where this is going. This is a gigantic PR (likely out of necessity). I'm guessing you have other PRs planned.

I would rather not block progress, but please review the suggestions.

@raju-opti raju-opti merged commit 9e37f00 into master Oct 4, 2024
11 of 19 checks passed
@raju-opti raju-opti deleted the raju/event-processor branch October 4, 2024 17:11
@raju-opti raju-opti restored the raju/event-processor branch November 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants