-
Notifications
You must be signed in to change notification settings - Fork 83
[FSSDK-10643] make event processor injectable #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Have some queries -
- I was going through the TDD before reviewing this and I find
createQueuingEventProcessor
which is missing from this commit. Are you planning to do that on the future? Or you are happy with the currentcreateEventProcessor
as it is. - I am seeing some commented code and unused imports across the platform specific files. I have just put "Cleanup required" for each. Pardon me if I have missed any to mark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP still reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like where this is going. This is a gigantic PR (likely out of necessity). I'm guessing you have other PRs planned.
I would rather not block progress, but please review the suggestions.
Summary
createStaticEventProcessor
factory method.Test plan
Issues