[FSSDK-9433]: Adds support to override sdkName and sdkVersion for events #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Jun 16, 2023
| @@ -84,12 +86,13 @@ open class OptimizelyClient: NSObject { | |||
| odpManager: OdpManager? = nil, | |||
| defaultLogLevel: OptimizelyLogLevel? = nil, | |||
| defaultDecideOptions: [OptimizelyDecideOption]? = nil, | |||
| settings: OptimizelySdkSettings? = nil) { | |||
| settings: OptimizelySdkSettings? = nil, | |||
| clientName: String? = nil) { | |||
There was a problem hiding this comment.
Can we move this new option into OptimizelySdkSettings? It's not a common configuration usage.
There was a problem hiding this comment.
We also need to config "sdkVersion" as well.
We can use "sdkName" and "sdkVersion" to be consistent with android-sdk?
| @@ -744,7 +750,7 @@ open class OptimizelyClient: NSObject { | |||
| throw OptimizelyError.eventKeyInvalid(eventKey) | |||
| } | |||
|
|
|||
| sendConversionEvent(eventKey: eventKey, userId: userId, attributes: attributes, eventTags: eventTags) | |||
| sendConversionEvent(eventKey: eventKey, userId: userId, attributes: attributes, eventTags: eventTags, clientName: self.clientName) | |||
There was a problem hiding this comment.
I think we can change Utils.sdkVersion and Utils.swiftSdkClientName to update when customize. In that way, we do not change these apis.
| @@ -285,7 +289,8 @@ open class OptimizelyClient: NSObject { | |||
| attributes: attributes, | |||
| flagKey: "", | |||
| ruleType: Constants.DecisionSource.experiment.rawValue, | |||
| enabled: true) | |||
| enabled: true, | |||
| clientName: clientName) | |||
There was a problem hiding this comment.
Same as before. If we change Utils.sdkVersion, no need for this change.
jaeopt
requested changes
Jun 20, 2023
Comment on lines
31
to
32
| Utils.sdkVersion = OPTIMIZELYSDKVERSION | ||
| Utils.swiftSdkClientName = "swift-sdk" |
There was a problem hiding this comment.
Do we need this lines for testing? It may be more interesting without them to check if all works fine with default config.
yasirfolio3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues