Skip to content

[FSSDK-6907]: Adds a check to only save valid datafile in cache. #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Adds a check to only save valid datafile in cache.

Test plan

  • New unit tests added
  • All previous unit tests should pass

Issues

jaeopt
jaeopt previously approved these changes Jun 23, 2023
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a small change (no print)

Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
@yasirfolio3 yasirfolio3 reopened this Jun 26, 2023
@yasirfolio3 yasirfolio3 merged commit 236d76d into master Jun 26, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-6907 branch June 26, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants