[FSSDK-9508] refact: Implements a warning log for polling interval less than 30s #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
previously approved these changes
Jul 13, 2023
Sources/Utils/LogMessage.swift
Outdated
| @@ -128,6 +129,7 @@ extension LogMessage: CustomStringConvertible { | |||
| case .failedToConvertMapToString: message = "Provided map could not be converted to string." | |||
| case .failedToAssignValue: message = "Value for path could not be assigned to provided type." | |||
| case .valueForKeyNotFound(let key): message = "Value for JSON key (\(key)) not found." | |||
| case .lowPeriodicDownloadInterval: message = "Polling interval below 30s can create high number of requests." | |||
There was a problem hiding this comment.
What do you think about "Polling intervals below 30 seconds are not recommended."?
There was a problem hiding this comment.
Sounds good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues