[FSSDK-10761] feat: make vuid as opt-in #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Oct 23, 2024
Sources/ODP/OdpManager.swift
Outdated
| vuid = userId | ||
| fsUserId = nil | ||
| eventManager.identifyUser(vuid: userId, userId: nil) | ||
| } else if let _vuid = vuid { |
There was a problem hiding this comment.
We also need the case covered -
vuid: nil and
user_id: valid not vuid
There was a problem hiding this comment.
I believe we have unit tests for all these combos. If missed, can we add one?
There was a problem hiding this comment.
Yah, test case is failing. Made the vuid optional to identifyUser.
func identifyUser(vuid: String?, userId: String?) {
var identifiers = [String: String]()
if let _vuid = vuid {
identifiers[Constants.ODP.keyForVuid] = _vuid
}
| let logger = OPTLoggerFactory.getLogger() | ||
|
|
||
| // a single vuid should be shared for all SDK instances | ||
| static let shared = OdpVuidManager() |
There was a problem hiding this comment.
We should keep it a singleton, so can share a single vuid per device.
There was a problem hiding this comment.
Declared singleton and add initialize method.
static let shared = VuidManager()
func initialize(enabled: Bool) {
self.enabled = enabled
if enabled {
self._vuid = load()
} else {
self.remove()
}
}
* master: [FSSDK-10771] Implement UPS request batching for decideForKeys (#559) # Conflicts: # OptimizelySwiftSDK.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logical changes when vuid is not enabled
Test plan
Issues