Исправление привнесенных ошибок #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5024366.
artbear
requested changes
Nov 8, 2017
| Для Каждого Строка Из ТаблицаХранилища Цикл | ||
|
|
||
| СтрокаПользователя = ТаблицаСопоставления.Найти(строка.Автор, "Автор"); | ||
| Если СтрокаПользователя = Неопределено Тогда | ||
|
|
||
| СтрокаСообщения = СтрШаблон("Пользователю хранилища <%1> не сопоставлен пользователь git.",строка.Автор); | ||
| Если ПроверитьАвторовХранилища Тогда | ||
| МассивСообщенийОбОшибочныхАвторах.Добавить(СтрокаСообщения); | ||
| Если МассивСообщенийОбОшибочныхАвторах.Найти(строка.Автор) = Неопределено Тогда |
There was a problem hiding this comment.
Если мы все равно ищем в массив, и добавляем, если не найдено, то проще вместо массива юзать Соответствие
| @@ -38,7 +38,7 @@ | |||
| // | |||
| Функция ВерсияПродукта() Экспорт | |||
|
|
|||
| Возврат "2.2.1"; | |||
| Возврат "2.3.0"; | |||
There was a problem hiding this comment.
Неверно менять версию в девелоп-ветке :(
Менять нужно при выпуске релиза
Откатывай строку
There was a problem hiding this comment.
Это не мои строчки... Это то что отсутвует в develop - прямые изменения в master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@artbear - Надо поскорее влить.