WHIP: Fix bugs #19
Open
WHIP: Fix bugs #19
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
reviewed
Jun 5, 2025
JackLau1222
force-pushed
the
fix_tls_build
branch
2 times, most recently
from
1c0802c to
6b8e626
Compare
JackLau1222
force-pushed
the
fix_tls_build
branch
from
6b8e626 to
28d01bb
Compare
winlinvip
force-pushed
the
workflows
branch
8 times, most recently
from
d8fca42 to
aa84960
Compare
fix the missing data structure pkey in the tls_context Signed-off-by: Jack Lau <jacklau1222@qq.com>
Signed-off-by: Jack Lau <jacklau1222@qq.com>
JackLau1222
force-pushed
the
fix_tls_build
branch
from
28d01bb to
2e5e91b
Compare
In higher versions (like openssl 1.1.1 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), which leads to warnings. OpenSSL guarantees that it will not modify the string, so it's safe to cast the pem_str to (void *) to avoid this warning. Signed-off-by: Jack Lau <jacklau1222@qq.com>
api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem In higher versions (openssl 1.0.2 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), which leads to warnings. OpenSSL guarantees that it will not modify the string, so it's safe to cast the pem_str to (void *) to avoid this warning. Signed-off-by: Jack Lau <jacklau1222@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the whip code in FFmpeg master and #18 , it aims to improve this feature
Key Changes:
avformat/tls_openssl: fix build error when openssl version < 3
Progress
the early two commits has been merged in ffmpeg master FFmpeg@4611ed5
the latest commit
[avformat/tls_openssl: fix warnings when openssl is lower version](https://github.com/ossrs/ffmpeg-webrtc/pull/19/commits/9368f77e9c0071888b92066e98d82d28cf25ebf3)has been reviewed by Steven Liu, waiting to merge, then this PR will be closedUsage
You can follow the usage to test this patch.