Skip to content

BUG: update dict of sheets before check #27730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pandas/io/excel/_openpyxl.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,11 @@ def write_cells(

_style_cache = {}

# Update sheet list
self.sheets = {}
for wks in self.book.worksheets:
self.sheets[wks.title] = wks

if sheet_name in self.sheets:
wks = self.sheets[sheet_name]
else:
Expand Down
11 changes: 8 additions & 3 deletions pandas/tests/io/excel/test_openpyxl.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,26 @@ def test_write_cells_merge_styled(ext):


@pytest.mark.parametrize(
"mode,expected", [("w", ["baz"]), ("a", ["foo", "bar", "baz"])]
"mode,expected", [("w", ["new_sheet"]),
("a", ["foo", "bar", "existing_sheet", "new_sheet"])]
)
def test_write_append_mode(ext, mode, expected):
df = DataFrame([1], columns=["baz"])
df_new_sheet = DataFrame([1], columns=["new_sheet"])
df_existing_sheet = DataFrame([1], columns=["existing_sheet"])

with ensure_clean(ext) as f:
wb = openpyxl.Workbook()
wb.worksheets[0].title = "foo"
wb.worksheets[0]["A1"].value = "foo"
wb.create_sheet("bar")
wb.worksheets[1]["A1"].value = "bar"
wb.create_sheet("existing_sheet")
wb.save(f)

writer = ExcelWriter(f, engine="openpyxl", mode=mode)
df.to_excel(writer, sheet_name="baz", index=False)
if mode == "a":
df_existing_sheet.to_excel(writer, sheet_name="existing_sheet", index=False)
df_new_sheet.to_excel(writer, sheet_name="new_sheet", index=False)
writer.save()

wb2 = openpyxl.load_workbook(f)
Expand Down