Skip to content

TYP: Add mypy as a pre-commit #30682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

TYP: Add mypy as a pre-commit #30682

merged 1 commit into from
Jan 4, 2020

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Jan 4, 2020

This is quite helpful in developing with typing, especially if you plan to update the mypy version.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@alimcmaster1 alimcmaster1 added the Typing type annotations, mypy/pyright type checking label Jan 4, 2020
alimcmaster1
alimcmaster1 approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this - LGTM

@jreback jreback added this to the 1.0 milestone Jan 4, 2020
@jreback jreback merged commit 5384552 into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks @xhochy

@xhochy xhochy deleted the mypy-pre-commit branch January 4, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xhochy @jreback @alimcmaster1