REF: share comparison methods for DTA/TDA/PA #30751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jan 6, 2020
|
|
||
| from pandas.tseries import frequencies | ||
| from pandas.tseries.offsets import DateOffset, Tick | ||
|
|
||
| from .base import ExtensionArray, ExtensionOpsMixin | ||
|
|
||
|
|
||
| def _datetimelike_array_cmp(cls, op): |
There was a problem hiding this comment.
This isn't an exact copy of dt_array_cmp right? If not can you help point out where integrates from period / td methods?
There was a problem hiding this comment.
i put some comments in when moving this, are there specific parts that arent clear?
|
thanks @jbrockmendel @WillAyd this was one of the goals of the last series of PRs that @jbrockmendel did, to make identical code in the subclasses. (and now this consolidates it). |
|
Yep makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.