REF: re-use tz_convert_from_utc_single in _localize_tso #46525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased? |
has been rebased following #46516, im not aware of anything relevant since then |
|
looks like those were xpasses, should now be unfixed |
|
green |
mroeschke
approved these changes
Mar 29, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely sits on top of #46516
The observation is that what _localize_tso is doing is similar to what tz_convert_from_utc_single is doing if we could just get a couple more pieces of information back from the latter call. Getting
foldback is easy to do by passing via pointer (which we do elsewhere). Gettingnew_tzback is uglier but its the best we got. (im assuming that returning a tuple(int64_t, bint, Py_ssize_t)would incur a perf penalty but ive bothered the cython folks enough already recently)May be able to get some extra de-duplication in _create_tsobject_tz_using_offset and/or ints_to_pydatetime. But I'm skittish perf-wise.
#46516 should definitely be merged. This I won't be offended if reviewers ask for %timeits out the wazoo.
At some point, someone with just the right amount of adderall drip should figure out the optimal way to check for `typ=="dateutil" etc.