-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DEPS: Make pytz an optional dependency #59089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+222
−186
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
51dfbe7
Make pytz an optional dependency
mroeschke ff76e49
Start to address tests
mroeschke 10df94e
Fix tests
mroeschke b76fca7
Fix tests
mroeschke 19d424b
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke 7d1b37b
Fix test, import optional pytz in conftest
mroeschke a6d703e
Fix formatting
mroeschke 2153987
Change minimum
mroeschke ee34f5a
remove type ignore
mroeschke 74263d3
another pa under 17
mroeschke 3be94bf
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke 6690eaa
Address comments
mroeschke 3b7a526
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke db94b7e
Undo file
mroeschke f9f92af
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke dce0c35
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke b252886
Merge branch 'main' into deps/pytz/optional
mroeschke f55e413
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke d15f8e1
Merge branch 'deps/pytz/optional' of https://github.com/mroeschke/pan…
mroeschke e8b2c8c
Merge branch 'main' into deps/pytz/optional
mroeschke 445842e
Merge remote-tracking branch 'upstream/main' into deps/pytz/optional
mroeschke c59f52e
Fix pyarrow 17 test
mroeschke 62cc55e
Merge branch 'main' into deps/pytz/optional
mroeschke 95415ff
Merge branch 'main' into deps/pytz/optional
mroeschke be76d11
Merge branch 'main' into deps/pytz/optional
mroeschke 9a0b4c1
Test xpasses on pyarrow 18
mroeschke 589ca49
Merge branch 'main' into deps/pytz/optional
mroeschke 02b9527
Merge branch 'main' into deps/pytz/optional
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,6 @@ dependencies: | |
|
||
# pandas dependencies | ||
- python-dateutil | ||
- pytz | ||
- pip | ||
|
||
- pip: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ dependencies: | |
# required dependencies | ||
- python-dateutil | ||
- numpy<2 | ||
- pytz | ||
- pip | ||
|
||
- pip: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,5 @@ dependencies: | |
# required | ||
- numpy | ||
- python-dateutil | ||
- pytz | ||
- pip: | ||
- tzdata>=2022.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit confusing. It suggests, that pd.Timestamp and others can be used to make it do return
pytz
objects.