-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: Add Timedelta accepting float value #60058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ZKaoChi , See the error message for the failed test:
(Keep lines below 89 characters.) |
@5j9 I see. Thanks a lot!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another suggestion: I'd use a more descriptive commit title. Something that gives more information about the issue at hand rather than just referring to issue number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! small request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @ZKaoChi |
Thanks a lot for your help. |
value
parameter ofpandas.Timedelta
can also accept float #60044