Skip to content

DOC: Add Timedelta accepting float value #60058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2024
Merged

DOC: Add Timedelta accepting float value #60058

merged 8 commits into from
Oct 29, 2024

Conversation

ZKaoChi
Copy link
Contributor

@ZKaoChi ZKaoChi commented Oct 16, 2024 •
edited
Loading

@ZKaoChi ZKaoChi requested a review from MarcoGorelli as a code owner October 16, 2024 12:23
@5j9
Copy link
Contributor

5j9 commented Oct 16, 2024

@ZKaoChi , See the error message for the failed test:

cython-lint.............................................................................................Failed
- hook id: cython-lint
- exit code: 1

/code/pandas/_libs/tslibs/timedeltas.pyx:1871:89: E501 line too long (149 > 88 characters)

(Keep lines below 89 characters.)

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Oct 16, 2024

@5j9 I see. Thanks a lot!!!

5j9
5j9 reviewed Oct 17, 2024
View reviewed changes
5j9
5j9 reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@5j9 5j9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion: I'd use a more descriptive commit title. Something that gives more information about the issue at hand rather than just referring to issue number.

rhshadrach
rhshadrach requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! small request.

@rhshadrach rhshadrach added Docs Timedelta Timedelta data type labels Oct 26, 2024
@ZKaoChi ZKaoChi closed this Oct 28, 2024
@ZKaoChi ZKaoChi reopened this Oct 29, 2024
@ZKaoChi ZKaoChi closed this Oct 29, 2024
@ZKaoChi ZKaoChi reopened this Oct 29, 2024
rhshadrach
rhshadrach approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach changed the title DOC: Solution for issue #60044 DOC: Add documentation on Timedelta accepting float value Oct 29, 2024
@rhshadrach rhshadrach changed the title DOC: Add documentation on Timedelta accepting float value DOC: Add Timedelta accepting float value Oct 29, 2024
@mroeschke mroeschke merged commit b5c7f25 into pandas-dev:main Oct 29, 2024
50 of 51 checks passed
@mroeschke
Copy link
Member

Thanks @ZKaoChi

@mroeschke mroeschke added this to the 3.0 milestone Oct 29, 2024
@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Oct 30, 2024

Thanks a lot for your help.

@ZKaoChi ZKaoChi deleted the Solution-for-issue-#60044 branch October 30, 2024 11:14
@ZKaoChi ZKaoChi restored the Solution-for-issue-#60044 branch October 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5j9 5j9 5j9 left review comments

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

Assignees
No one assigned
Labels
Docs Timedelta Timedelta data type
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

DOC: The value parameter of pandas.Timedelta can also accept float
4 participants
@ZKaoChi @5j9 @mroeschke @rhshadrach