PERF: avoid object-dtype path in ArrowEA._explode #61786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
force-pushed
the
perf-explode
branch
from
c0e1865 to
0ac9567
Compare
mroeschke
reviewed
Jul 7, 2025
| # pc.if_else here is similar to `values[mask] = fill_value` | ||
| # but this avoids an object-dtype round-trip. | ||
| pa_values = pc.if_else(~mask, values._pa_array, fill_value) | ||
| values = type(self)(pa_values) | ||
| counts = counts.copy() |
There was a problem hiding this comment.
Unrelated, but this need to be a copy (since it comes from a computed operation already)?
There was a problem hiding this comment.
i dont see why it would. will remove it in my next "assorted cleanups" branch
mroeschke
approved these changes
Jul 7, 2025
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified in #61732