Parse.Schema required fields and defaultValues #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #930 Requires Parse Server 3.7.0+ Feature: parse-community/parse-server#5835 I added a FieldOption to addField and its counter parts. This will allow for future options like uppercase / lowercase for example. I keep getting a schema mismatch when I use dates and pointers. @davimacedo Maybe you know why?
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 91.9% 91.94% +0.04%
==========================================
Files 54 54
Lines 5063 5077 +14
Branches 1134 1142 +8
==========================================
+ Hits 4653 4668 +15
+ Misses 410 409 -1
Continue to review full report at Codecov.
|
|
@acinader @davimacedo How does this look? |
acinader
approved these changes
Oct 16, 2019
src/__tests__/ParseSchema-test.js
Outdated
| @@ -69,6 +83,30 @@ describe('ParseSchema', () => { | |||
| done(); | |||
| }); | |||
|
|
|||
| it('can create schema fields required and default values', (done) => { | |||
There was a problem hiding this comment.
since this doesn't require any async, you could remove the done from the func declaration and remove the end done().
This was referenced Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #930
Requires Parse Server 3.7.0+
Feature: parse-community/parse-server#5835
I added a FieldOption to addField and its counter parts. This will allow for future options like uppercase / lowercase for example.