-
-
Notifications
You must be signed in to change notification settings - Fork 877
feat: Add LiveQuery module to SDK #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
132a8d1
b3c945c
4728be4
f7405fc
a33ca50
7656ec8
24bfff1
ab190eb
4f80d5c
07836f0
de5b6c7
56f90c8
5a4b32f
2eea533
1f02173
abd8feb
413aec7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
github "BoltsFramework/Bolts-ObjC" ~> 1.9.1 | ||
github "BoltsFramework/Bolts-Swift" >= 1.5.0 | ||
github "facebook/facebook-ios-sdk" == 15.1.0 | ||
github "daltoniam/Starscream" >= 4.0.4 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
github "BoltsFramework/Bolts-ObjC" "1.9.1" | ||
github "BoltsFramework/Bolts-Swift" "1.5.0" | ||
github "daltoniam/Starscream" "4.0.4" | ||
github "facebook/facebook-ios-sdk" "v15.1.0" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,19 +10,22 @@ let package = Package( | |
.tvOS(.v12), | ||
.watchOS(.v2)], | ||
products: [ | ||
.library(name: "ParseObjC", targets: ["ParseCore"]), | ||
.library(name: "ParseObjC", targets: ["Parse"]), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change and is this a breaking change? It seems a bit odd to name the core module There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, yes it is an important change because in SDK target has the name "Parse". When we set "ParseCore" it causes an error downloading. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure I understand. Why can't we keep the name There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mtrezza This is my first time using SPM and I didn't know you had to do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @vazarkevych Could you take a look at this so we can close this PR? It seems to be the last remaining issue here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mtrezza Can you commit 1 example of tedious work? I'll finish the rest. I don't quite understand what needs to be changed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #1712 (comment). The module name So I'd simply remove the renaming and then go into the LiveQuery module and make sure it uses the
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
Sorry, something went wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dplewis Do you want to take a look at this, we could add an additional bounty. |
||
.library(name: "ParseFacebookUtilsiOS", targets: ["ParseFacebookUtilsiOS"]), | ||
.library(name: "ParseFacebookUtilsTvOS", targets: ["ParseFacebookUtilsTvOS"]), | ||
.library(name: "ParseTwitterUtils", targets: ["ParseTwitterUtils"]), | ||
.library(name: "ParseUI", targets: ["ParseUI"]) | ||
.library(name: "ParseUI", targets: ["ParseUI"]), | ||
.library(name: "ParseLiveQuery", targets: ["ParseLiveQuery"]) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/parse-community/Bolts-ObjC.git", from: "1.10.0"), | ||
.package(url: "https://github.com/BoltsFramework/Bolts-Swift.git", from: "1.5.0"), | ||
.package(url: "https://github.com/daltoniam/Starscream.git", from: "4.0.4"), | ||
.package(url: "https://github.com/facebook/facebook-ios-sdk.git", from: "15.1.0") | ||
], | ||
targets: [ | ||
.target( | ||
name: "ParseCore", | ||
name: "Parse", | ||
dependencies: [.product(name: "Bolts", package: "Bolts-ObjC")], | ||
path: "Parse/Parse", | ||
exclude: ["Resources/Parse-tvOS.Info.plist", "Resources/Parse-iOS.Info.plist", "Resources/Parse-OSX.Info.plist", "Resources/Parse-watchOS.Info.plist"], | ||
|
@@ -32,7 +35,7 @@ let package = Package( | |
.target( | ||
name: "ParseFacebookUtils", | ||
dependencies: [ | ||
"ParseCore", | ||
"Parse", | ||
.product(name: "Bolts", package: "Bolts-ObjC"), | ||
.product(name: "FacebookCore", package: "facebook-ios-sdk", condition: .when(platforms: [.iOS, .tvOS])), | ||
.product(name: "FacebookLogin", package: "facebook-ios-sdk", condition: .when(platforms: [.iOS, .tvOS]))], | ||
|
@@ -61,7 +64,7 @@ let package = Package( | |
cSettings: [.headerSearchPath("Internal/**")]), | ||
.target(name: "ParseTwitterUtils", | ||
dependencies: [ | ||
"ParseCore" | ||
"Parse" | ||
], | ||
path: "ParseTwitterUtils/ParseTwitterUtils", | ||
exclude: ["Resources/Info-iOS.plist"], | ||
|
@@ -78,5 +81,14 @@ let package = Package( | |
resources: [.process("Resources")], | ||
publicHeadersPath: "Source", | ||
cSettings: [.headerSearchPath("Internal/**")]), | ||
.target(name: "ParseLiveQuery", | ||
dependencies: [ | ||
.product(name: "BoltsSwift", package: "Bolts-Swift"), | ||
"Starscream", | ||
"Parse" | ||
], | ||
path: "ParseLiveQuery/ParseLiveQuery", | ||
exclude: ["Resources/Info.plist"], | ||
resources: [.process("Resources")]) | ||
] | ||
) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.