Updates various tests. #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates a pair of test cases with a small time delay so that updatedAt related queries will return as expected
acinader
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #312.
Updates a mocking test to utilize phpunit 4's approach to mocking objects. This looks to be forward compatible with later versions as well, meaning we can upgrade to a currently supported version of phpunit when we feel the need.
Updates a pair of test cases in ParseQueryTest with a small time delay so that updatedAt based queries will return as expected. Prior to this both test cases attempted would save all objects in one
ParseObject::saveAllcall. This could lead to the update times being identical potentially, and the objects could return in an flip-flop fashion in regards to order.Also noticed that one of the aforementioned Query tests was checking for objects in the wrong order. This was possible given the ambiguous time sorting of objects, which had the same update times.
@acinader if you can verify these changes have the intended effect on your end I would appreciate it!