Skip to content

Pages autodeploy and phpdoc style enforcing #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 12, 2017

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Jul 12, 2017

This adds document-check to package.json to allow enforcement of phpdoc standards. This also modifies .travis.yml to run this check after the tests are done. Via document-check checkstyle.xml is checked for any errors, and if found will exit with code 1.

This also adds a deployment phase to automatically setup our gh-pages on each release, which must currently be done by hand. By enforcing document-check in the existing test-suite we can be sure that our generated api reference is 💯 % and always up to date for each release.

This will require a github token in order to function.

If there's an existing one we'll be good, right now it's just stubbed out from the docs. But if not we have the option of either passing it directly in this file or setting it up as an environment var. Either works, assuming this gets a go ahead.

There's a few other parameters that can be specified when deploying to pages, we could pass an email, name, etc. if desired.

@codecov
Copy link

codecov bot commented Jul 12, 2017

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          34       34           
  Lines        2696     2696           
=======================================
  Hits         2663     2663           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b760ca3...ad917d5. Read the comment docs.

@montymxb montymxb requested a review from flovilmart July 12, 2017 02:19
@flovilmart
Copy link
Contributor

That's pretty cool! Wish we could enforce those org wide :)

Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very cool! where are the pages deployed? on gh-pages?

@montymxb
Copy link
Contributor Author

@flovilmart Yep, the api ref is published under gh-pages @ http://parseplatform.org/parse-php-sdk/namespaces/Parse.html. I've uploaded changes by hand before before, but this should be much better, especially with enforcement in place.

The one thing I still have is to setup a token for travis to be able to push up on the gh-pages branch. I'm going to ahead and set that up before this goes in. Other than that I think we're good, but I'll let you know if I need anything for setting it up deployment with travis.

@montymxb montymxb merged commit b148730 into parse-community:master Jul 12, 2017
@montymxb montymxb deleted the pages-deploy branch July 12, 2017 03:00
dplewis pushed a commit to dplewis/parse-php-sdk that referenced this pull request Jul 12, 2017
* Added 'document-check' to add phpdoc checking during tests and added deploy for api ref on gh-pages

* Wrapping filename in quotes

* Moved bash out of package.json

* Unescaping strings

* Testing missing block comment

* Fixing lint exception to expose phpdoc style issue

* Restored class summary

* removed comment
montymxb pushed a commit that referenced this pull request Jul 12, 2017
* Add ParsePolygon Type and polygonContains query

* test class fix

* error handling for polygon

* Update PHP_CodeSniffer (#328)

* Add lint

* update travis

* coding style

* add coverage to gitignore

* removed ignore lines

* nit

* Updated parse-php-sdk to version 1.2.9

* Corrects and updates phpdoc references/errors (#329)

* Corrects and updates phpdoc references/errors

* Lint fixes

* Added 'Getting Started' to README.md

Adds a **Getting Started** section to README.md to direct newcomers to the [official guide](http://docs.parseplatform.org/php/guide/) and [API reference](http://parseplatform.org/parse-php-sdk/namespaces/Parse.html).

* Remove Default API (#332)

* Removed default api and added appropriate checking

* lint

* Pages autodeploy and phpdoc style enforcing (#335)

* Added 'document-check' to add phpdoc checking during tests and added deploy for api ref on gh-pages

* Wrapping filename in quotes

* Moved bash out of package.json

* Unescaping strings

* Testing missing block comment

* Fixing lint exception to expose phpdoc style issue

* Restored class summary

* removed comment

* fix documentation

* Pinned jms/serializer to 1.7.1 (#336)

* Pinned jms/serializer to 1.7.1

* Checking to update jms/serializer to 1.8.0 ONLY on php 5.4 for travis-ci

* Added comment, and added graphviz for class diagrams in generated api docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants