Skip to content

Remove simple-mailgun-adapter dependency #7320

Closed
@mtrezza

Description

@mtrezza

New Feature / Enhancement Checklist

Current Limitation

Parse Server has a dependency on parse-server-simple-mailgun-adapter, which is an old adapter that does not support custom emailVerification or passwordReset emails, so it seems more like a proof-of-concept.

Parse Server today has multiple mail adapters that provide much more functionality. Keeping that adapter as a dependency just for adapter loading tests is unnecessary. The adapter also needs to be maintained and current has a high security vulnerability, the package is lacking tests and other basics like lint. In short, we wouldn't want to keep a poorly maintained adapter is presumably not much in use as part of Parse Server.

Feature / Enhancement Description

The suggestion is to:

  • replace the adapter with sub-package inside the Parse Server package (for adapter module loading tests)
  • deprecate the parse-server-simple-mailgun-adapter

Alternatives / Workarounds

Fix the security vulnerability in the mailgun adapter. I already did that via parse-community/parse-server-simple-mailgun-adapter#37, but the new adapter needs to be tested.

3rd Party References

n/a

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions