Fix RT #97625 use-after-free in mysql_dr_error, and #86153 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2014 15:24
free imp_dbh->pmysql in my_login matching the allocation. In the success case, imp_dbh->pmysql is freed seperately later in dbd_db_destroy(). This reverts the wrong leak-fix from RT #86153 and adds the real fix for it.
|
See additional comments in https://rt.cpan.org/Ticket/Display.html?id=97625#txn-1393444 This my_login fix does not yet fix the same error with reconnects via mysql_auto_reconnect. |
CaptTofu
added a commit
that referenced
this pull request
Aug 1, 2014
Fix RT #97625 use-after-free in mysql_dr_error, and #86153
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.