Method chaining indentation

[khalyomede]

Currently I will write method chaining like this:

final class User
{
  public function scopeAuthor(Builder $query): Builder
  {
    return $query->whereIn("status", [
        User::STATUS_SUSPENDED, 
        User::STATUS_BANNED, 
      ])
      ->where("active", true) 
      ->whereHas("books");
  } 
} 

I know I was writing the methods chaining like this a while ago

final class User extends Model
{
  public function scopeAuthor(Builder $query): Builder
  {
    return $query->whereIn("status", [
      User::STATUS_SUSPENDED, 
      User::STATUS_BANNED, 
    ])
    ->where("active", true) 
    ->whereHas("books");
  } 
}

I've seen on Twitter people use a trick when the first method call is multiline

final class User
{
  public function scopeAuthor(Builder $query): Builder
  {
    return $query->new()
      ->whereIn("status", [
        User::STATUS_SUSPENDED, 
        User::STATUS_BANNED, 
      ])
      ->where("active", true) 
      ->whereHas("books");
  } 
} 

Maybe it's worth considering adding a word about it.

[andrewprofile]

the first and second versions are identical👯

[khalyomede]

Pay attention to spaces 😜

[samdark]

Related to #16

[KorvinSzanto]

#16 resolves this by requiring the first method be placed on the next line when breaking chained function calls across multiple lines.