Full symfony 4 dependencies #232
Conversation
fbourigault
force-pushed
the
full-symfony-4-dependencies
branch
from
1ed2d12 to
d36dc50
Compare
|
We need a new release of https://github.com/php-http/client-common! |
.travis.yml
Outdated
| cache: | ||
| directories: | ||
| - $HOME/.composer/cache/files | ||
| - $HOME/symfony-bridge/.phpunit | ||
|
|
||
| env: | ||
| global: | ||
| - TEST_COMMAND="composer test" |
There was a problem hiding this comment.
The php-http organisation has (maybe silently) decided that all our packages should be tested with composer test and composer test-ci.
We do not need the PHPUNIT_FLAGS. You should revert this and continue using TEST_COMMAND
There was a problem hiding this comment.
Ok. I pushed a better version IMHO. Let's see what's the build result.
fbourigault
force-pushed
the
full-symfony-4-dependencies
branch
from
7cea880 to
e514408
Compare
fbourigault
force-pushed
the
full-symfony-4-dependencies
branch
from
e514408 to
85f9571
Compare
fbourigault
changed the title
|
This is now ready to merge. |
.travis.yml
Outdated
|
|
||
| allow_failures: | ||
| # dev-master is allowed to fail. | ||
| - php: 7.1 | ||
| env: DEPENDENCIES="dev" | ||
| - php: 7.2 |
There was a problem hiding this comment.
according to the symfony docs PR, you can drop this and just keep the bit about env to allow failures
There was a problem hiding this comment.
You mean:
allow_failures:
env: DEPENDENCIES="dev"?
There was a problem hiding this comment.
yes. see https://github.com/symfony/symfony-docs/pull/8701/files#diff-9d0d9156660f746e55727b52fcbf918dR214 - it will be good to see here if that works as expected ;-)
There was a problem hiding this comment.
We will not be able to know this with this PR as its 100% green ;)
There was a problem hiding this comment.
we can see it: when you click on the build, you see a travis page where the allowed to fail build are separated, even if they succeed.
the point of omitting the php version is that we don't care about the version and when php 7.3 comes out we would forget to adjust this line.
|
🎉 |
This is a tentative to test against Symfony 4 only dependencies.
As @Nyholm has now merge rights on
matthiasnoback/symfony-config-testandmatthiasnoback/symfony-dependency-injection-test, we will be able to get this working.Once those versions will be tagged, tell me so I will be able to rebase and remove the dev-dependency.