TypeError: Argument 1 passed to ProfileClient::collectExceptionInformations() must be an instance of Exception #353
Conversation
spolischook
changed the title
spolischook
force-pushed
the
bug/catch_throwable_exceptions
branch
from
1274012 to
81c63ff
Compare
|
@Nyholm @fbourigault @dbu could you please approve/merge it? |
| * | ||
| * @return string | ||
| */ | ||
| public function formatException(Exception $exception) | ||
| public function formatException(\Throwable $exception) |
There was a problem hiding this comment.
This is not a BC break because the class is internal.
There was a problem hiding this comment.
even more, Throwable is wide variation of Exception, so no BC break will happen
There was a problem hiding this comment.
Yes. But that reason alone is still a BC break because the class is not final.
| @@ -34,7 +35,7 @@ class ProfileClientTest extends TestCase | |||
| private $activeStack; | |||
|
|
|||
| /** | |||
| * @var HttpClient | |||
| * @var HttpClient|MockObject | |||
There was a problem hiding this comment.
right.
just a comment, no need to change anything now: i have seen the syntax HttpClient&MockObject which is semantically correct and needed from some phpstan level on so phpstan is sure about the type of the variable. however, e.g. phpstorm seems not to know about it...
There was a problem hiding this comment.
Yea, it's right, PhpStorm don't suggest any method of MockObject so I should to add this,
What's in this PR?
Fix error
Why?
Checklist
To Do