Compatibility issue with Twig 2.7.0+

[Kocal]

Hi,

I wanted to update Twig from 2.6.2 to 2.7.0 because of a security issue:

However, I'm facing a compatibility issue:

Since Twig 2.7.0, they don't use class aliases anymore (e.g.: Twig_Environment) but class namespaces (e.g. Twig\Environment) directly, refs:

• https://symfony.com/blog/new-in-twig-namespaced-classes
• Switch to namespaces (2.x) twigphp/Twig#2863
• Move some more PSR0 class names to namespaced ones twigphp/Twig#2869
• changelog

I tried to fork and replace class aliases by class namespaces, but it's out of my scope.
I don't have the time to do it, I don't know about your breaking changes policy, I don't know if I should update the .travis.yml to use a specific version of Twig... 😕

Thanks!

[Kocal]

Also, someone opened an issue about this on the Twig repo: twigphp/Twig#2886

So maybe we will have nothing to upgrade here

[mdeboer]

@Kocal I checked the dependencies and as far as I can tell, it's safe to use namespaced classes instead of class aliases.

Even though the referenced issue and PR might solve the issue for now, why not make sure it does not happen again. Getting rid of the trickery involved with aliases.

[Kocal]

Well, in fact it's fixed by twigphp/Twig#2887

So I'm closing this one :)

[stof]

Migrating to namespaced Twig classes might still be a good idea though, as Twig 3.x will remove non-namespaced classes.

[Kocal]

Yep of course!

[Kocal]

I opened a PR (#290) which replace Twig aliases.