Skip to content

Only measure code coverage on Unit tests. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2018
Merged

Only measure code coverage on Unit tests. #242

merged 1 commit into from
Jun 26, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 26, 2018

It takes too much time to see code coverage on the functional tests. PHPUnit has to keep track on all the Symfony stack.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 26, 2018

This will bring back the build to green

@Nyholm Nyholm merged commit c9c04e1 into master Jun 26, 2018
@Nyholm Nyholm deleted the patch-execution-time branch June 26, 2018 12:53
rvanlaak
rvanlaak reviewed Jun 26, 2018
View reviewed changes
Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍 Functional tests should not get covered, as that also means the coverage includes everything the container does.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 26, 2018

Yeah, a cheap trick to improve the test coverage. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanlaak rvanlaak rvanlaak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @rvanlaak