Skip to content

WebUI - Template block names #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

lsv
Copy link
Contributor

@lsv lsv commented Nov 22, 2018

Changed the block names, so its not using the "default" ones, so its much easier to overwrite the base template, so it can be fitted into your own admin view.

So you doesnt need to overwrite 3 templates, but can overwrite just the base template

@lsv
Copy link
Contributor Author

lsv commented Nov 22, 2018

travis is failing due to it can not download phpunit zip archive

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, actually FOSUserBundle follows the same strategy IIRC 👍

@bocharsky-bw
Copy link
Member

@lsv Could you rebase with latest changes in master to see if tests pass here, please?

@Nyholm
Copy link
Member

Nyholm commented Jul 20, 2019

Good idea!

Thank you

@Nyholm Nyholm merged commit 6e6b7b7 into php-translation:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants