Skip to content

Allow Symfony 4.2 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow Symfony 4.2 #322

wants to merge 1 commit into from

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Jul 22, 2019

Symfony 4.2 introduced ICU MessageFormat. However, this bundle doesn't use it and yet the test is being executed because the test suite extends Symfony\Component\Translation\Tests\Catalogue\MergeOperationTest that contains an additional test. I suggest to skip it for now.

@XWB XWB requested a review from Nyholm July 22, 2019 20:46
@Nyholm
Copy link
Member

Nyholm commented Jul 23, 2019

This seams like a Volkswagen approach :)

The implementation is still broken. We will loose information every time we extract new keys from source. That is clearly a bug that we should not merge, right?

@bocharsky-bw
Copy link
Member

bocharsky-bw commented Jul 23, 2019

Hm, probably the question is whether users use ICU MessageFormat or no. If they do - then this bundle will work incorrectly and they will lose information every time they extract new keys from the source. But if they don't - probably it should work fine (though not sure 100%). Anyway, I think we can't just assume that users won't use ICU MessageFormat, so agree, would be better to fix this properly.

@XWB
Copy link
Contributor Author

XWB commented Jul 23, 2019

@Nyholm Is it a bug, or just a missing feature in this bundle?

@Nyholm
Copy link
Member

Nyholm commented Jul 23, 2019

It is a bug if we allow 4.2 since the ReplaceOperation will not work properly with the icu messages.

@XWB XWB closed this Jul 23, 2019
@XWB XWB deleted the s42 branch July 23, 2019 12:50
@XWB
Copy link
Contributor Author

XWB commented Jul 23, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants