Skip to content

Support for all Symfony translation versions #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2019
Merged

Support for all Symfony translation versions #327

merged 3 commits into from
Sep 5, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Sep 5, 2019

This will replace #323 and fix #321

I basically rewrote and simplified ReplaceOperation.

XWB
XWB reviewed Sep 5, 2019
View reviewed changes
@Nyholm Nyholm mentioned this pull request Sep 5, 2019
Merged
@XWB XWB merged commit 928d5d2 into master Sep 5, 2019
@XWB XWB deleted the support-intl branch September 5, 2019 14:49
@XWB XWB mentioned this pull request Sep 5, 2019
Closed
@Nyholm
Copy link
Member Author

Nyholm commented Sep 5, 2019

Thank you for merging.

@bocharsky-bw
Copy link
Member

Thank you for working on it! 🎉

@bobdenotter
Copy link
Contributor

Thank you for this release! Works like a charm in our project!

Screenshot 2019-09-05 at 20 45 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XWB XWB XWB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

symfony/translation 4.2
4 participants
@Nyholm @bocharsky-bw @bobdenotter @XWB