allow symfony 5

[Jeroeny]

#SymfonyHackday

[Nyholm]

Thank you. It seams like there are some updates in the translation component that we need to take care of. Check the PHPStan report.

[Jeroeny]

Thank you. It seams like there are some updates in the translation component that we need to take care of. Check the PHPStan report.

It used a deprecated function indeed. I've added an if statement that checks if the function exists. However I'm not sure if an exception should be thrown or - like I've done now - the $names should be empty ([]).

Edit: And PhpStan still doesn't like it.

[welcoMattic]

I fix a conflict on composer.json file directly on GitHub. The last thing is to fix cs 👍
@Jeroeny could you fix it please?

[odolbeau]

I think we can safely ignore PHPStan errors WDYT?

 ------ ------------------------------------------------- 
  Line   Controller/WebUIController.php                   
 ------ ------------------------------------------------- 
  215    Call to an undefined static method               
         Symfony\Component\Intl\Intl::getLocaleBundle().  
 ------ ------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   DependencyInjection/Configuration.php                             
 ------ ------------------------------------------------------------------ 
  39     Call to an undefined method                                       
         Symfony\Component\Config\Definition\Builder\TreeBuilder::root().  
 ------ ------------------------------------------------------------------ 

[odolbeau]

Looks great! WDYT @welcoMattic?

[welcoMattic]

LGTM too! Well done @Jeroeny, thank you!
@odolbeau do you think that we must merge #345 before?

[odolbeau]

I tried to rebase #344 on master: this PR is not ready (yet) to be merged.
We should merge this one right now I think.

[welcoMattic]

Ok, I let you merge this one 😉

[Nyholm]

Wohoo! Great work!