-
Notifications
You must be signed in to change notification settings - Fork 93
add service definition for form field title extractor #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version 2.0.1 of extractor released! |
what's the state of this PR? anything to do in order to get it merged? |
Could you remove the non-trigerred PHPStan error & replace the service declaration with the code suggested by @rvanlaak please?
It will avoid the current Travis error when the bundle is used with a It's done in #396 but this PR does several things. :/ |
Please do so when clicking on the merge button. |
This PR adds a service definition for the extractor wanted in #394
Do not merge before php-translation/extractor#148 is merged.