Skip to content

add service definition for form field title extractor #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2020
Merged

add service definition for form field title extractor #395

merged 8 commits into from
Feb 17, 2020

Conversation

Guite
Copy link
Contributor

@Guite Guite commented Jan 22, 2020

This PR adds a service definition for the extractor wanted in #394

Do not merge before php-translation/extractor#148 is merged.

@odolbeau
Copy link
Member

Version 2.0.1 of extractor released!
https://github.com/php-translation/extractor/releases/tag/2.0.1

@Guite
Copy link
Contributor Author

Guite commented Feb 9, 2020

what's the state of this PR? anything to do in order to get it merged?

@odolbeau
Copy link
Member

odolbeau commented Feb 9, 2020

Could you remove the non-trigerred PHPStan error & replace the service declaration with the code suggested by @rvanlaak please?

_instanceof:
    PhpParser\NodeVisitor:
        tags:
            - { name: 'php_translation.visitor', type: 'php' }

It will avoid the current Travis error when the bundle is used with a php-translation/extractor version which doesn't contain the new visitor.

It's done in #396 but this PR does several things. :/

@Guite
Copy link
Contributor Author

Guite commented Feb 9, 2020

@odolbeau done both but eventually this lead to including almost everything from #396 - except the autowire enablement.

@odolbeau
Copy link
Member

@Guite could you squash your commits please?
@rvanlaak WDYT?
It it OK for you if we merge this PR which is now ready to be merged or do you prefer to correct #396?

@Guite
Copy link
Contributor Author

Guite commented Feb 10, 2020

could you squash your commits please?

Please do so when clicking on the merge button.

@rvanlaak rvanlaak merged commit 50e54c5 into php-translation:master Feb 17, 2020
@welcoMattic welcoMattic mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants