Simplify extractor service configuration #396
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,111 +1,76 @@ | ||
| services: | ||
| _defaults: | ||
| autowire: true | ||
|
There was a problem hiding this comment. As discussed in #372 we should not use There was a problem hiding this comment. Will remove it from the defaults 👍 The bundle currently has 4 occurences of using autowiring, so moving it to the level of the service itself seems ok: https://github.com/php-translation/symfony-bundle/search?q=autowire%3A+true&unscoped_q=autowire%3A+true |
||
| bind: | ||
| $metadataFactory: '@validator' | ||
|
|
||
| _instanceof: | ||
| PhpParser\NodeVisitor: | ||
| tags: | ||
| - { name: 'php_translation.visitor', type: 'php' } | ||
|
|
||
| Translation\Extractor\FileExtractor\PHPFileExtractor: | ||
|
There was a problem hiding this comment. Could we / should we use the same logic for extractors or does it makes no sense? There was a problem hiding this comment. What logic are you referring to? |
||
| tags: | ||
| - { name: 'php_translation.extractor', type: 'php' } | ||
|
|
||
| Translation\Extractor\FileExtractor\TwigFileExtractor: | ||
| tags: | ||
| - { name: 'php_translation.extractor', type: 'twig' } | ||
|
|
||
| # PHP Visitors: | ||
| Translation\Extractor\Visitor\Php\Symfony\: | ||
| resource: "%extractor_vendor_dir%/Visitor/Php/Symfony/*" | ||
|
|
||
| Translation\Extractor\Visitor\Php\SourceLocationContainerVisitor: ~ | ||
odolbeau marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Twig Visitors: | ||
| Translation\Extractor\Visitor\Twig\TwigVisitor: | ||
| tags: | ||
| - { name: 'php_translation.visitor', type: 'twig' } | ||
|
|
||
| # To remove in next major release | ||
| php_translation.extractor.php: | ||
| alias: Translation\Extractor\FileExtractor\PHPFileExtractor | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.twig: | ||
| alias: Translation\Extractor\FileExtractor\TwigFileExtractor | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.ContainerAwareTrans: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\ContainerAwareTrans | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.ContainerAwareTransChoice: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\ContainerAwareTransChoice | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FlashMessage: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FlashMessage | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeChoices: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeChoices | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeEmptyValue: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeEmptyValue | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeHelp: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeHelp | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeInvalidMessage: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeInvalidMessage | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeLabelExplicit: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeLabelExplicit | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypeLabelImplicit: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypeLabelImplicit | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.FormTypePlaceholder: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\FormTypePlaceholder | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.ValidationAnnotation: | ||
| alias: Translation\Extractor\Visitor\Php\Symfony\ValidationAnnotation | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.php.visitor.SourceLocationContainerVisitor: | ||
| alias: Translation\Extractor\Visitor\Php\SourceLocationContainerVisitor | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
| php_translation.extractor.twig.factory.twig: | ||
| alias: Translation\Extractor\Visitor\Twig\TwigVisitor | ||
| deprecated: 'The "%service_id%" service is deprecated. You should use "%alias_id%" instead, as it will be removed in the future.' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it be problematic in some edge cases?
For example, if you use a deployment server to warmup the cache before deploying , as the
dirnamefunction use the absolute path, it will be problematic if your project is not on the same location on your deployment server & your production server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I used
FormTypeChoicesis because that class already was in code, and thereby already is loadable. IfFormTypeChoiceswould not be supported anymore in the future, more functionality will break. As the extension only runs on compilation of the container, this will keep working.Related to the
dirnamefunction; Wouldn't the composer autoload then also break? The warmup will lead to a compiled container, so the path only is used to locate the classes in a resource. Afterwards, on runtime the composer autoloader will take over again.