Skip to content

allow null values in CheckMissingCommand #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

allow null values in CheckMissingCommand #407

merged 1 commit into from
Feb 24, 2020

Conversation

Guite
Copy link
Contributor

@Guite Guite commented Feb 23, 2020

This PR ensures that translation:check-missing does not break if a null value is given to the closure used in countEmptyTranslations method.

Error message:

In CheckMissingCommand.php line 137:
                                                                               
Argument 1 passed to Translation\Bundle\Command\CheckMissingCommand::Translation\Bundle\Command\{closure}() must be of the type string, null given

@odolbeau odolbeau merged commit 7f737fe into php-translation:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odolbeau odolbeau odolbeau approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guite @odolbeau @welcoMattic